Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize LTS communication handling #5864

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Generalize LTS communication handling #5864

merged 4 commits into from
Mar 28, 2024

Commits on Mar 18, 2024

  1. Remove hardcoding of LTS steppers to one substep

    @wthrowe
    wthrowe committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    b94c922 View commit details
    Browse the repository at this point in the history

  2. Move neighbor data dependence logic to steppers 

    Not obviously the same for all time steppers, and will not be as
simple as a less-than comparison for AMPC.
    @wthrowe
    wthrowe committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    6869681 View commit details
    Browse the repository at this point in the history

  3. Make TimeStepId comparisons a total order 

    Required for std::map<TimeStepId, T> to work with data from neighbors.
    @wthrowe
    wthrowe committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    e50e07d View commit details
    Browse the repository at this point in the history

  4. Don't assume boundary data is sorted by use order 

    It's sorted by TimeStepId, but that may not agree with the order the
messages need to be processed in, depending on the TimeStepper in use.
    @wthrowe
    wthrowe committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    aeacc36 View commit details
    Browse the repository at this point in the history