Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge implementations of Interval, Rectangle, and Brick #5898

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Apr 1, 2024

Proposed changes

I needed different boundary conditions in each direction in 2D, but it was only supported in 3D. Also, only the 1D domain supported log/inverse grid point distributions. So I merged the three implementations into one.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu changed the title Merge implementations of Interval, Rectangle, and Brick domains Merge implementations of Interval, Rectangle, and Brick Apr 1, 2024
@nilsvu nilsvu force-pushed the rectangle_bc branch 4 times, most recently from d1a2b5e to b0274ae Compare April 1, 2024 23:46
@knelli2
Copy link
Contributor

knelli2 commented Aug 21, 2024

@nilsvu will rebase since this is something we want

Only do the rename so source control keeps track of the file changes.
@nilsvu
Copy link
Member Author

nilsvu commented Aug 21, 2024

@sxs-collaboration/spectre-core-devs could someone review this one? I rebased it and it's running through CI now.

@nilsdeppe
Copy link
Member

I can review this

Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can squash

src/Domain/CoordinateMaps/Distribution.cpp Show resolved Hide resolved
tests/Unit/Domain/Creators/Test_Brick.cpp Show resolved Hide resolved
I needed different boundary conditions in each direction in 2D, but it was
only supported in 3D. Also, only the 1D domain supported log/inverse grid point
distributions. So I merged the three implementations into one.
@nilsdeppe nilsdeppe added the auto-merge GitHub's auto-merge has been enabled for this PR. label Aug 21, 2024
@nilsvu nilsvu merged commit 54ba225 into sxs-collaboration:develop Aug 22, 2024
20 of 22 checks passed
@nilsvu nilsvu deleted the rectangle_bc branch August 22, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge GitHub's auto-merge has been enabled for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants