Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlignedLattice: boundary condition per direction #6241

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Aug 22, 2024

Proposed changes

Allows to specify a different boundary condition in each direction of the AlignedLattice, just like the rectilinear domains (Interval/Rectangle/Brick).

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu
Copy link
Member Author

nilsvu commented Aug 23, 2024

@nilsdeppe mind taking a look at this one too? It's doing the same as #5898 in terms of boundary conditions for AlignedLattice. We might even be able to merge the AlignedLattice features into Rectilinear, but that's a bit more work that I haven't attempted.

Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

In the future could you please try to keep things like renames of VolumeDim -> Dim in separate commits to make it easier to review?

@nilsvu
Copy link
Member Author

nilsvu commented Aug 24, 2024

Yes I should've done that in a separate commit

@nilsvu nilsvu merged commit e95d592 into sxs-collaboration:develop Aug 25, 2024
20 of 22 checks passed
@nilsvu nilsvu deleted the aligned_lattice_bc branch August 25, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants