Fix iterations test failure #6225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikwit
added
the
small
knelli2
requested changes
Aug 16, 2024
| std::uniform_real_distribution<> vel_dist(-0.3, 0.3); | ||
| std::uniform_real_distribution<> vel_dist(-0.2, 0.2); |
There was a problem hiding this comment.
Could you add a note about why the magnitude of the velocity can't be larger than 0.2? I'm guessing too large a velocity causes something (the worldtube?) to move too much
There was a problem hiding this comment.
I am actually not sure why, as the worldtube is still going slower than the speed of light. I have not debugged what breaks then in this test but this was never encountered in a simulation.
knelli2
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested 30k times without failure
addresses #6001