Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iterations test failure #6225

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Fix iterations test failure #6225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/Unit/Evolution/Systems/CurvedScalarWave/Worldtube/ElementActions/Test_Iterations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ void test_iterations(const size_t max_iterations) {
MAKE_GENERATOR(generator);
std::uniform_real_distribution<> dist(-10., 10.);
std::uniform_real_distribution<> pos_dist(2., 10.);
std::uniform_real_distribution<> vel_dist(-0.3, 0.3);
std::uniform_real_distribution<> vel_dist(-0.2, 0.2);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a note about why the magnitude of the velocity can't be larger than 0.2? I'm guessing too large a velocity causes something (the worldtube?) to move too much

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am actually not sure why, as the worldtube is still going slower than the speed of light. I have not debugged what breaks then in this test but this was never encountered in a simulation.

using metavars = MockMetavariables<Dim>;
domain::creators::register_derived_with_charm();
using element_chare = MockElementArray<metavars>;
Expand Down
Loading