Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single BH control system #6247

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Aug 24, 2024

Proposed changes

Controls object to the origin of the domain.

Upgrade instructions

Must now specify a Translation: control system in EvolveGhSingleBlackHole input files.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments


namespace control_system::ControlErrors {
template struct Translation<1_st>;
template struct Translation<2_st>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don't do anything useful because the class is entirely defined in the hpp.

@@ -246,6 +246,22 @@ ControlSystems:
WriteDataToDisk: false
MeasurementsPerUpdate: 4
Verbosity: Silent
Translation:
IsActive: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to turn this on?

@knelli2
Copy link
Contributor Author

knelli2 commented Sep 6, 2024

Squashed everything in

wthrowe
wthrowe previously approved these changes Sep 9, 2024
Copy link
Member

@wthrowe wthrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy timed out for no obvious reason. Rerunning to see if it was some sort of glitch. If it still times out I'm not going to worry about it.

@knelli2
Copy link
Contributor Author

knelli2 commented Sep 9, 2024

@wthrowe I've seen clang-tidy time out on several PRs lately for what seems like no good reason (not that many files changed). I haven't tried to figure out why though

@wthrowe
Copy link
Member

wthrowe commented Sep 10, 2024

Sounds like you fixed it in #6282. Want to rebase to pick that up?

@knelli2
Copy link
Contributor Author

knelli2 commented Sep 10, 2024

I don't think #6282 was the issue as I'm pretty sure the clang-tidy timeouts were happening before I introduced that, but I rebased just in case.

@wthrowe
Copy link
Member

wthrowe commented Sep 10, 2024

Actually, looks like your fix broke it more. CI is spewing errors.

@wthrowe
Copy link
Member

wthrowe commented Sep 10, 2024

And then reporting itself as passed.

Copy link
Member

@wthrowe wthrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that fixed clang-tidy. One of the errors there is legitimate, but it wasn't introduced in this PR and we should get the fix in quickly, so I'm not going to worry about it.

@wthrowe wthrowe merged commit 9dfc5f6 into sxs-collaboration:develop Sep 11, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants