Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang-tidy quirk #6282

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Sep 10, 2024

Proposed changes

My bad for missing this. It's causing clang-tidy to fail on all PRs that have been rebased.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 added small Only changes a few lines of code, does a rename or is otherwise quick to review bugfix labels Sep 10, 2024
@nilsdeppe nilsdeppe merged commit 5be062b into sxs-collaboration:develop Sep 10, 2024
23 checks passed
@wthrowe wthrowe mentioned this pull request Sep 10, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix small Only changes a few lines of code, does a rename or is otherwise quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants