-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoolTimeout exceptions on requests to Tumblr #4
Comments
Related: encode/httpx#1171 |
Seems like the problem is not just limited to media requests. The regular client used for requesting Tumblr's API seems to also be affected. |
According to the upstream issue, it seems like the problem is due to the fact that clients aren't released from the connection pool when the request is canceled. Shielding the request from being canceled is reported as a workaround for the issue. |
#4 appears to be caused by faulty connections that aren't properly released which will result in a PoolTimeout exception when attempting to fetch one. When enough of a pool gets poisoned, all requests will fail due to the PoolTimeout exceptions. This commit implements a workaround by detecting and then reinitializing poisoned connection pools which would clear all of the faulty connections.
#4 appears to be caused by faulty connections that aren't properly released which will result in a PoolTimeout exception when attempting to fetch one. When enough of a pool gets poisoned, all requests will fail due to the PoolTimeout exceptions. This commit implements a workaround by detecting and then reinitializing poisoned connection pools which would clear all of the faulty connections.
#4 appears to be caused by faulty connections that aren't properly released which will result in a PoolTimeout exception when attempting to fetch one. When enough of a pool gets poisoned, all requests will fail due to the PoolTimeout exceptions. This commit implements a workaround by detecting and then reinitializing poisoned connection pools which would clear all of the faulty connections.
Issue still seems to occur |
httpx has reportedly fixed the issue here encode/httpcore#880 It should be fine for us to switch back to httpx now. |
Priviblur can sometimes stop working randomly due to a permanent pool timeout exception. Directly accessing Tumblr works as expected
This is most commonly seen in the media requests, meaning that all pages still works fine just without any media assets loaded. However, it seems like regular requests can also be affected resulting in a pool timeout exception page on all Priviblur routes.
It seems to be reproducible after extensive usage.
A restart is able to fix this.
More investigation needed.
The text was updated successfully, but these errors were encountered: