Add workaround for poisoned connection pool #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#4 appears to be caused by faulty connections that aren't properly released which will result in a PoolTimeout exception when attempting to fetch one. When enough of a pool gets poisoned, all requests will fail due to the PoolTimeout exceptions. This commit implements a workaround by detecting and then reinitializing poisoned connection pools which would clear all of the faulty connections.
syeopite
force-pushed
the
frozen-requests-workaround
branch
from
a8d052f
to
080e709
Compare
|
@extremelyonline I've noticed that your instance is pretty heavily affected by #4. Could you try and see if this patch fixes it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4 appears to be caused by faulty connections that aren't properly released which will result in a PoolTimeout exception when attempting to fetch one.
When enough of a pool gets poisoned, all requests will fail due to the PoolTimeout exceptions.
This commit implements a workaround by detecting and then reinitializing poisoned connection pools which would clear all of the faulty connections.
Closes #4