Fixing support for webpack-dev-server v4 #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
commented
Jan 28, 2021
| @@ -42,7 +42,6 @@ module.exports = function(argv, cwd) { | |||
|
|
|||
| runtimeConfig.useDevServer = true; | |||
| runtimeConfig.devServerHttps = argv.https; | |||
| runtimeConfig.useHotModuleReplacement = argv.hot || false; | |||
There was a problem hiding this comment.
hot now defaults to true. So there is no option at the command line and no need for us to set anything.
weaverryan
commented
Jan 28, 2021
| compress: true, | ||
| historyApiFallback: true, | ||
| watchOptions: this.buildWatchOptionsConfig(), |
There was a problem hiding this comment.
This now lives under static.watch. However, it automatically reads the root-level watchOptions config and uses that as its defaults - https://github.com/webpack/webpack-dev-server/blob/788f2ba7d9152610ba0d3024f0079c98aad86991/lib/utils/normalizeOptions.js#L9-L23 - so we don't need to re-set the options here also.
stof
reviewed
Jan 28, 2021
weaverryan
force-pushed
the
fixing-dev-server-v4
branch
from
b9a849b
to
23a981f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #893