Working around missing manifest.json bug #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
force-pushed
the
workaround-missing-manifest
branch
from
6ed2047 to
a4a6665
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the 2nd part of #893 - #893 (comment)
On Webpack 5, there is some miscommunication between the CleanWebpackPlugin and the WebpackManifestPlugin when using
dev-server.The
WebpackManifestPlugindoes emit the physicalmanifest.jsonfile, but CleanWebpackPlugin then deletes it. CleanWebpackPlugin should just remove files before we start, and not delete anything that's emitted. I'm not sure which plugin has the bug. But, the work around is quite clean.