Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving handling of boilerplate configuration #609

Closed
racke opened this issue May 2, 2019 · 0 comments · Fixed by #619
Closed

Improving handling of boilerplate configuration #609

racke opened this issue May 2, 2019 · 0 comments · Fixed by #619
Assignees
Labels
bug ready A PR is waiting to be merged. Close to be solved
Milestone

Comments

@racke
Copy link
Contributor

racke commented May 2, 2019

# /sbin/sympa.pl --health_check
err Conf::_set_listmasters_entry() Robot (You must define this parameter) config: Listmaster address "(Youmustdefinethisparameter)" is not a valid email
err Conf::_set_listmasters_entry() Robot (You must define this parameter) config: All the listmasters addresses found were not valid. Out of 1 addresses provided, 0 only are valid email addresses
Bareword found where operator expected at (eval 279) line 1, near "require Sympa::DatabaseDriver::(You"
	(Do you need to predeclare require?)
Database sympa defined in sympa.conf has not the right structure or is unreachable. verify db_xxx parameters in sympa.conf

The command above is designed to test Sympa configuration and thus shouldn't crash on the boilerplate configuration file. It should certainly not try to load a database driver in case the db_type is obviously invalid.

Version

6.2.42

Installation method

RPM

@ikedas ikedas added the bug label May 7, 2019
@ldidry ldidry self-assigned this May 17, 2019
ldidry added a commit to ldidry/sympa that referenced this issue May 17, 2019
@ldidry ldidry added the ready A PR is waiting to be merged. Close to be solved label May 17, 2019
ldidry added a commit to ldidry/sympa that referenced this issue May 17, 2019
ldidry added a commit to ldidry/sympa that referenced this issue May 17, 2019
ldidry added a commit to ldidry/sympa that referenced this issue May 17, 2019
ldidry added a commit to ldidry/sympa that referenced this issue May 24, 2019
ldidry added a commit to ldidry/sympa that referenced this issue May 24, 2019
@ikedas ikedas added this to the 6.2.44 milestone May 27, 2019
ikedas added a commit that referenced this issue May 28, 2019
Fix #609 — Handle boilerplate db_type conf in sympa.pl --health_check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ready A PR is waiting to be merged. Close to be solved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants