Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #609 — Handle boilerplate db_type conf in sympa.pl --health_check #619

Merged
merged 2 commits into from
May 28, 2019
Merged

Fix #609 — Handle boilerplate db_type conf in sympa.pl --health_check #619

merged 2 commits into from
May 28, 2019

Conversation

ldidry
Copy link
Contributor

@ldidry ldidry commented May 17, 2019

Fix #609

@ldidry ldidry requested review from ikedas, dverdin and racke May 17, 2019 13:19
@ldidry ldidry added the bug label May 17, 2019
@ldidry ldidry force-pushed the fix-609 branch 2 times, most recently from a80c00f to 1f5d10f Compare May 17, 2019 13:21
@racke
Copy link
Contributor

racke commented May 17, 2019

Good ... a bit rewording maybe?

is the boilerplate one and is obviously incorrect

I suggest to drop the second "is", otherwise it looks like you are talking about unrelated things.

@ldidry
Copy link
Contributor Author

ldidry commented May 17, 2019

Ok. Reworded 🙂

racke
racke approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@racke racke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ikedas ikedas merged commit ee8ba15 into sympa-community:sympa-6.2 May 28, 2019
@ldidry ldidry deleted the fix-609 branch June 25, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikedas ikedas ikedas approved these changes

@racke racke racke approved these changes

@dverdin dverdin Awaiting requested review from dverdin

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improving handling of boilerplate configuration
3 participants
@ldidry @racke @ikedas