[misc] Remove debug info in release mode #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archibate
approved these changes
May 19, 2020
| @@ -31,7 +31,7 @@ FILE(WRITE ${CMAKE_CURRENT_LIST_DIR}/docs/version | |||
| ) | |||
|
|
|||
| if(NOT CMAKE_BUILD_TYPE) | |||
| set(CMAKE_BUILD_TYPE "RelWithDebInfo" CACHE STRING | |||
| set(CMAKE_BUILD_TYPE "Release" CACHE STRING | |||
There was a problem hiding this comment.
- So, will a developer get
CMAKE_BUILD_TYPE=Releaseby default? They have to setCMAKE_BUILD_TYPE=RelWithDebInfomanually?
There was a problem hiding this comment.
- Please see [PyPI] Linux package much bigger than Windows and OS X #1017 (comment)
- You still get the backtrace but some detailed debug symbols might be missing. I never use those symbols anyway
- Yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #1017
I'll just merge this after CI passes.
[Click here for the format server]