-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Improve dev_install for Windows and LLVM 10 #1202
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1202 +/- ##
==========================================
- Coverage 67.09% 66.85% -0.25%
==========================================
Files 35 35
Lines 4835 4827 -8
Branches 886 885 -1
==========================================
- Hits 3244 3227 -17
- Misses 1417 1424 +7
- Partials 174 176 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving the developer docs. Just a few tweaks.
Hi Yuanming, Should we also address the multiple instances of MSBUILD.exe on Windows (first commit in #1021)? Like a simple note in the ymal file? This stuck me for a long time once. |
Sure thing I will handle the conflict there.~ Thanks LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much clearer doc!
LGTM
Co-authored-by: 彭于斌 <1931127624@qq.com>
Related issue = #655