Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Improve dev_install for Windows and LLVM 10 #1202

Merged
merged 6 commits into from
Jun 11, 2020

Conversation

yuanming-hu
Copy link
Member

@yuanming-hu yuanming-hu commented Jun 10, 2020

@yuanming-hu yuanming-hu requested review from Eydcao and TH3CHARLie June 10, 2020 03:20
@yuanming-hu yuanming-hu changed the title [doc] Improve dev_install [doc] Improve dev_install for Windows and LLVM 10 Jun 10, 2020
@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #1202 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1202      +/-   ##
==========================================
- Coverage   67.09%   66.85%   -0.25%     
==========================================
  Files          35       35              
  Lines        4835     4827       -8     
  Branches      886      885       -1     
==========================================
- Hits         3244     3227      -17     
- Misses       1417     1424       +7     
- Partials      174      176       +2     
Impacted Files Coverage Δ
python/taichi/lang/matrix.py 82.93% <0.00%> (-1.86%) ⬇️
python/taichi/lang/util.py 50.93% <0.00%> (-0.90%) ⬇️
python/taichi/lang/kernel.py 78.49% <0.00%> (-0.32%) ⬇️
python/taichi/lang/common_ops.py 90.55% <0.00%> (-0.06%) ⬇️
python/taichi/main.py 43.53% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2169c98...e9d2d74. Read the comment docs.

Copy link
Collaborator

@TH3CHARLie TH3CHARLie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the developer docs. Just a few tweaks.

docs/dev_install.rst Show resolved Hide resolved
docs/dev_install.rst Show resolved Hide resolved
docs/dev_install.rst Outdated Show resolved Hide resolved
docs/dev_install.rst Outdated Show resolved Hide resolved
docs/dev_install.rst Outdated Show resolved Hide resolved
docs/dev_install.rst Outdated Show resolved Hide resolved
docs/dev_install.rst Show resolved Hide resolved
docs/dev_install.rst Show resolved Hide resolved
docs/dev_install.rst Outdated Show resolved Hide resolved
@Eydcao
Copy link
Contributor

Eydcao commented Jun 10, 2020

Hi Yuanming,

Should we also address the multiple instances of MSBUILD.exe on Windows (first commit in #1021)? Like a simple note in the ymal file? This stuck me for a long time once.

@yuanming-hu
Copy link
Member Author

Hi Yuanming,

Should we also address the multiple instances of MSBUILD.exe on Windows (first commit in #1021)? Like a simple note in the ymal file? This stuck me for a long time once.

Sure, please do that in #1021. Sorry about getting you stuck!

@Eydcao
Copy link
Contributor

Eydcao commented Jun 10, 2020

Hi Yuanming,
Should we also address the multiple instances of MSBUILD.exe on Windows (first commit in #1021)? Like a simple note in the ymal file? This stuck me for a long time once.

Sure, please do that in #1021. Sorry about getting you stuck!

Sure thing I will handle the conflict there.~ Thanks LGTM!

Copy link
Contributor

@Eydcao Eydcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much clearer doc!

LGTM

docs/dev_install.rst Show resolved Hide resolved
docs/dev_install.rst Show resolved Hide resolved
@Eydcao Eydcao mentioned this pull request Jun 11, 2020
12 tasks
yuanming-hu and others added 3 commits June 11, 2020 07:50
@yuanming-hu yuanming-hu merged commit 4dfb598 into taichi-dev:master Jun 11, 2020
@FantasyVR FantasyVR mentioned this pull request Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants