Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Use PrimitiveType::type instead of DataType::type #1926

Merged
merged 2 commits into from
Oct 6, 2020

Conversation

taichi-gardener
Copy link
Contributor

Related issue = #1905

The goal of this PR is to remove usages of DataType.

[Click here for the format server]


@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #1926 into master will increase coverage by 0.84%.
The diff coverage is 23.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1926      +/-   ##
==========================================
+ Coverage   42.91%   43.76%   +0.84%     
==========================================
  Files          45       45              
  Lines        6410     6202     -208     
  Branches     1101     1101              
==========================================
- Hits         2751     2714      -37     
+ Misses       3489     3319     -170     
+ Partials      170      169       -1     
Impacted Files Coverage Δ
python/taichi/lang/util.py 32.93% <0.00%> (+0.38%) ⬆️
python/taichi/lang/kernel.py 71.39% <100.00%> (+0.35%) ⬆️
python/taichi/lang/__init__.py 40.45% <0.00%> (-2.17%) ⬇️
python/taichi/lang/ast_checker.py 70.58% <0.00%> (-1.64%) ⬇️
python/taichi/testing.py 75.00% <0.00%> (-0.72%) ⬇️
python/taichi/lang/linalg.py 89.33% <0.00%> (-0.67%) ⬇️
python/taichi/lang/meta.py 64.38% <0.00%> (-0.49%) ⬇️
python/taichi/misc/util.py 18.27% <0.00%> (-0.24%) ⬇️
python/taichi/misc/task.py 0.00% <0.00%> (ø)
python/taichi/tools/patterns.py 0.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 094baad...c42f9d0. Read the comment docs.

Copy link
Collaborator

@TH3CHARLie TH3CHARLie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just make sure to run ti format before the final merge

@yuanming-hu yuanming-hu merged commit 8a5035d into taichi-dev:master Oct 6, 2020
@yuanming-hu yuanming-hu deleted the remove-datatype branch October 6, 2020 05:00
@yuanming-hu yuanming-hu mentioned this pull request Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants