Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Type] [refactor] New type system #1905

Open
yuanming-hu opened this issue Sep 29, 2020 · 2 comments
Open

[Type] [refactor] New type system #1905

yuanming-hu opened this issue Sep 29, 2020 · 2 comments
Labels
feature request Suggest an idea on this project

Comments

@yuanming-hu
Copy link
Member

Concisely describe the proposed feature
The existing type system is rather simple and no longer serves the growing Taichi compiler well. We need to improve it.

Additional comments
Like #742, this is mainly a secret research project, but we will address a few engineering issues as by-products :-) This issue is merely used to track progress.
@yuanming-hu yuanming-hu added the feature request Suggest an idea on this project label Sep 29, 2020
@yuanming-hu yuanming-hu mentioned this issue Sep 29, 2020
Merged
@archibate archibate mentioned this issue Oct 6, 2020
Closed
@taichi-gardener taichi-gardener mentioned this issue Oct 6, 2020
Merged
@yuanming-hu yuanming-hu mentioned this issue Oct 12, 2020
Merged
@taichi-gardener taichi-gardener mentioned this issue Oct 12, 2020
Merged
@archibate
Copy link
Collaborator

A random thought, should we wrap the taichi_core.DataType with a Python class DataType with __repr__ and other stuffs? The old taichi_core.DataType could be put into dtype.ptr, like currently snode.ptr does.

TH3CHARLie pushed a commit that referenced this issue Oct 12, 2020
@yuanming-hu
[type] Initial TypeFactory class (#1942)
e33d6ed 
Related issue = #1905
@TH3CHARLie
Copy link
Collaborator

A random thought, should we wrap the taichi_core.DataType with a Python class DataType with __repr__ and other stuffs? The old taichi_core.DataType could be put into dtype.ptr, like currently snode.ptr does.

The old DatatType would be obsoleted in the short future so I think there's no need to do so.

@yuanming-hu yuanming-hu mentioned this issue Oct 13, 2020
Merged
@Hanke98 Hanke98 mentioned this issue Oct 14, 2020
Closed
@yuanming-hu yuanming-hu mentioned this issue Oct 14, 2020
Merged
@taichi-gardener taichi-gardener mentioned this issue Oct 15, 2020
Merged
@yuanming-hu yuanming-hu mentioned this issue Oct 16, 2020
Merged
@Hanke98 Hanke98 mentioned this issue Oct 16, 2020
Merged
@TH3CHARLie TH3CHARLie mentioned this issue Oct 16, 2020
Merged
@Hanke98 Hanke98 mentioned this issue Oct 17, 2020
Merged
@yuanming-hu yuanming-hu mentioned this issue Oct 17, 2020
Merged
@TH3CHARLie TH3CHARLie mentioned this issue Oct 20, 2020
Merged
@Hanke98 Hanke98 mentioned this issue Oct 26, 2020
Merged
@TH3CHARLie TH3CHARLie mentioned this issue Nov 1, 2020
Merged
TH3CHARLie added a commit that referenced this issue Nov 3, 2020
@TH3CHARLie
[type] Add BitArrayType and corresponding SNodes (#2017)
1ea0ec8 
Related issue = #1905, using #1968 as reference

Added BitArrayType
Added corresponding SNode API
misc/test_bit_array.py for demonstrating snode structures(and also a testcase for the future)
@archibate archibate mentioned this issue Nov 6, 2020
Merged
This was referenced Nov 6, 2020
Merged
Merged
@Hanke98 Hanke98 mentioned this issue Nov 6, 2020
Merged
@yuanming-hu yuanming-hu mentioned this issue Nov 10, 2020
Merged
This was referenced Nov 10, 2020
Merged
Merged
@Hanke98 Hanke98 mentioned this issue Nov 13, 2020
Merged
@yuanming-hu yuanming-hu mentioned this issue Dec 28, 2020
Merged
@TH3CHARLie TH3CHARLie mentioned this issue Dec 28, 2020
Merged
@yuanming-hu yuanming-hu mentioned this issue Dec 29, 2020
Merged
@TH3CHARLie TH3CHARLie mentioned this issue Dec 29, 2020
Merged
This was referenced Dec 29, 2020
Merged
Merged
@Hanke98 Hanke98 mentioned this issue Jan 1, 2021
Merged
@TH3CHARLie TH3CHARLie mentioned this issue Jan 1, 2021
Merged
This was referenced Jan 1, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@k-ye k-ye mentioned this issue Jan 6, 2021
Merged
This was referenced Jan 9, 2021
Merged
Merged
Merged
Merged
This was referenced Jan 20, 2021
Merged
Merged
@xumingkuan xumingkuan mentioned this issue Jan 24, 2021
Merged
@taichi-gardener taichi-gardener mentioned this issue Jan 24, 2021
Merged
This was referenced Jan 24, 2021
Merged
Merged
Merged
@xumingkuan xumingkuan mentioned this issue Apr 12, 2021
Merged
@Hanke98 Hanke98 mentioned this issue Jun 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Suggest an idea on this project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yuanming-hu @archibate @TH3CHARLie