Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] VectorType -> LegacyVectorType #1943

Merged
merged 2 commits into from
Oct 12, 2020

Conversation

taichi-gardener
Copy link
Contributor

Related issue = #1905

Making way for the real VectorType in the new type system.

[Click here for the format server]


@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #1943 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1943   +/-   ##
=======================================
  Coverage   43.72%   43.72%           
=======================================
  Files          45       45           
  Lines        6207     6207           
  Branches     1103     1103           
=======================================
  Hits         2714     2714           
  Misses       3322     3322           
  Partials      171      171           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db9ceeb...5192332. Read the comment docs.

Copy link
Contributor

@Hanke98 Hanke98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM! Thanks !

@yuanming-hu yuanming-hu merged commit d2129ee into taichi-dev:master Oct 12, 2020
@yuanming-hu yuanming-hu deleted the refactor-vector-type branch October 12, 2020 13:59
@yuanming-hu yuanming-hu mentioned this pull request Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants