Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] Add tests for refine_coordinates #2382

Merged
merged 4 commits into from
Jun 4, 2021
Merged

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented May 30, 2021

Related issue = #2327

A follow-up of #2327. Add tests for the JIT generated refine_coordinates(). Hopefully this servers as a better documentation for how the list-gen process works.

[Click here for the format server]


@k-ye k-ye requested review from KLozes and xumingkuan May 30, 2021 05:49
Copy link
Contributor

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

taichi/ir/ir_builder.h Outdated Show resolved Hide resolved
CompileConfig config_;
// We shouldn't need a Program instance in this test. Unfortunately, a few
// places depend on the global |current_program|, so we have to.
// ¯\_(ツ)_/¯
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¯\_(ツ)_/¯

@k-ye k-ye requested a review from BillXu2000 June 1, 2021 09:08
Copy link
Collaborator

@KLozes KLozes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too :)

@k-ye
Copy link
Member Author

k-ye commented Jun 2, 2021

/format

@k-ye
Copy link
Member Author

k-ye commented Jun 3, 2021

/format

@k-ye
Copy link
Member Author

k-ye commented Jun 3, 2021

/format

@k-ye k-ye merged commit 1d9be89 into taichi-dev:master Jun 4, 2021
@k-ye k-ye deleted the ref-coords branch June 4, 2021 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants