[ir] Make lower_scalar_pointer testable #2407
Merged
+451
−119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #2382
lower_scalar_pointer()
used to do three difference things:This PR pulls out step 1 into a separate class
ScalarPointerLowerer
to make it testable. Later we can also grow the logic around 1 separately (e.g. generate index decomposition statements for non power-of-two SNodes).Steps 2 and 3 still remain in the original
lower_acesss
pass.[Click here for the format server]