Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spirv] Add 16 bit float immediate number #4787

Merged
merged 3 commits into from
Apr 14, 2022

Conversation

bobcao3
Copy link
Collaborator

@bobcao3 bobcao3 commented Apr 14, 2022

Fixes #4757

@bobcao3 bobcao3 requested a review from lin-hitonami April 14, 2022 07:09
@netlify
Copy link

netlify bot commented Apr 14, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit f3f6012
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62585a0b88d0c30008a02d2f
😎 Deploy Preview https://deploy-preview-4787--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lin-hitonami
Copy link
Contributor

Could you add dt=ti.f16 to z here?

Copy link
Contributor

@lin-hitonami lin-hitonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lin-hitonami lin-hitonami merged commit 991990f into taichi-dev:master Apr 14, 2022
k-ye pushed a commit to k-ye/taichi that referenced this pull request May 5, 2022
* add 16 bit float immediate number

* Update f16 test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPIR-V backend does not support float immediate number of f16 type
2 participants