Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lang] Texture support 2/n (SPIR-V backend & runtime changes) #5159

Merged
merged 12 commits into from
Jun 15, 2022
Merged

[lang] Texture support 2/n (SPIR-V backend & runtime changes) #5159

merged 12 commits into from
Jun 15, 2022

Conversation

bobcao3
Copy link
Collaborator

@bobcao3 bobcao3 commented Jun 14, 2022

Related issue = #5109

@netlify
Copy link

netlify bot commented Jun 14, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit f1a87c2
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62a80193b0c3bd0008bc988c

@bobcao3 bobcao3 mentioned this pull request Jun 14, 2022
Merged
k-ye
k-ye approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

taichi/codegen/spirv/spirv_codegen.cpp Show resolved Hide resolved
@bobcao3 bobcao3 merged commit dbe032b into taichi-dev:master Jun 15, 2022
@bobcao3 bobcao3 deleted the bobcao3/texture branch June 15, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-ye k-ye k-ye approved these changes

@turbo0628 turbo0628 Awaiting requested review from turbo0628

@ailzhang ailzhang Awaiting requested review from ailzhang

@AmesingFlank AmesingFlank Awaiting requested review from AmesingFlank

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobcao3 @k-ye