Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] Texture support 3/n (Python changes) #5174

Merged
merged 22 commits into from
Jun 15, 2022

Conversation

bobcao3
Copy link
Collaborator

@bobcao3 bobcao3 commented Jun 14, 2022

Related issue = #5109

Depends on #5159

After this PR the initial support will be fully complete. Implementing textureGrad and textureGather should be straightforward small changes.

After the all the ones outlined in initial support is added with a test case, we should be able to release the API out to the wild.

@bobcao3 bobcao3 requested review from strongoier and ailzhang June 14, 2022 22:47
@netlify
Copy link

netlify bot commented Jun 14, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 396be6c
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62aa10ca8c84b800097895e4
😎 Deploy Preview https://deploy-preview-5174--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bobcao3 bobcao3 requested a review from k-ye June 14, 2022 22:47
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bobcao3 bobcao3 merged commit f38775c into taichi-dev:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants