Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type] [refactor] Consistently use quant_xxx in quant-related names #5166

Merged
merged 5 commits into from
Jun 15, 2022

Conversation

strongoier
Copy link
Contributor

Related issue = #4857, #3382

The co-existence of custom_xxx and quant_xxx adds unnecessary complexity to the codebase. After this PR, only quant_xxx is remained in quant-related names.

@netlify
Copy link

netlify bot commented Jun 14, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit ef8d493
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62a85110bb92f80008d24dea
😎 Deploy Preview https://deploy-preview-5166--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@strongoier strongoier requested review from k-ye and ailzhang June 14, 2022 10:05
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ailzhang ailzhang merged commit 61d09c2 into taichi-dev:master Jun 15, 2022
@strongoier strongoier deleted the rename-custom-to-quant branch June 15, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants