Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Refactor codegen_llvm.cpp #3382

Open
sjwsl opened this issue Nov 4, 2021 · 0 comments
Open

[refactor] Refactor codegen_llvm.cpp #3382

sjwsl opened this issue Nov 4, 2021 · 0 comments
Labels
c++ C++ engineering related potential bug Something that looks like a bug but not yet confirmed

Comments

@sjwsl
Copy link
Contributor

sjwsl commented Nov 4, 2021

Currently, https://github.com/taichi-dev/taichi/blob/master/taichi/codegen/codegen_llvm.cpp is full of if/else, which is ugly and hard to maintain. It's worth spending some time refactoring.
@sjwsl sjwsl added potential bug Something that looks like a bug but not yet confirmed c++ C++ engineering related labels Nov 4, 2021
@sjwsl sjwsl mentioned this issue Nov 4, 2021
Merged
This was referenced Jun 1, 2022
Merged
Merged
Merged
Merged
This was referenced Jun 9, 2022
Merged
Merged
Merged
Merged
@strongoier strongoier mentioned this issue Jul 8, 2022
Merged
@strongoier strongoier mentioned this issue Aug 31, 2022
Merged
@lin-hitonami lin-hitonami mentioned this issue Sep 28, 2022
Merged
ailzhang pushed a commit that referenced this issue Sep 29, 2022
@lin-hitonami @pre-commit-ci
[llvm] [refactor] Merge create_call and call (#6192)
9d65cbe 
Issue: #3382
Currently `create_call` in `TaskCodeGenLLVM` and `call` in
`LLVMModuleBuilder` do the same thing so they should be merged.
### Brief Summary

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c++ C++ engineering related potential bug Something that looks like a bug but not yet confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sjwsl