Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] [llvm] Unify llvm_type() and get_data_type() #5927

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

strongoier
Copy link
Contributor

Related issue = #3382

These functions are repeating each other. Let's only keep one.

@netlify
Copy link

netlify bot commented Aug 31, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit e2b477d
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/630f0dde68a9c40008ee6945
😎 Deploy Preview https://deploy-preview-5927--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@lin-hitonami lin-hitonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strongoier strongoier merged commit ffee072 into taichi-dev:master Aug 31, 2022
@strongoier strongoier deleted the remove-llvm-type branch September 1, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants