Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(audio): remove MediaStreamTrackAudioSourceNode #91

Merged
merged 1 commit into from
May 15, 2023
Merged

feat(audio): remove MediaStreamTrackAudioSourceNode #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion commitlint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@
module.exports = {extends: ['@commitlint/config-conventional']};
module.exports = {
extends: ['@commitlint/config-conventional'],
rules: {
'footer-max-line-length': [2, 'always', 200],
},
};
3 changes: 0 additions & 3 deletions libs/audio/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ You can use following audio nodes through directives of the same name (**prefixe

- [MediaElementAudioSourceNode](https://developer.mozilla.org/en-US/docs/Web/API/MediaElementAudioSourceNode)
- [MediaStreamAudioSourceNode](https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamAudioSourceNode)
- [MediaStreamTrackAudioSourceNode](https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamTrackAudioSourceNode)
- [OscillatorNode](https://developer.mozilla.org/en-US/docs/Web/API/OscillatorNode)

💡 Additionally supports empty `autoplay` attribute similar to `audio` tag so it would start playing immediately
Expand Down Expand Up @@ -327,8 +326,6 @@ envelope = [
[IIRFilterNode](https://developer.mozilla.org/en-US/docs/Web/API/IIRFilterNode)
- Provide `MEDIA_STREAM` token to be able to create
[MediaStreamAudioSourceNode](https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamAudioSourceNode)
- Provide `MEDIA_STREAM_TRACK` token to be able to create
[MediaStreamTrackAudioSourceNode](https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamTrackAudioSourceNode)
- All node directives provide underlying [AudioNode](https://developer.mozilla.org/en-US/docs/Web/API/AudioNode) as
`AUDIO_NODE` token
- Use `AUDIO_WORKLET_PROCESSORS` token to declare array of
Expand Down
2 changes: 0 additions & 2 deletions libs/audio/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ export * from './sources/buffer-source';
export * from './sources/constant-source';
export * from './sources/media-source';
export * from './sources/media-stream-source';
export * from './sources/media-stream-track-source';
export * from './sources/oscillator';

export * from './tokens/audio-context';
Expand All @@ -46,7 +45,6 @@ export * from './tokens/audio-worklet-support';
export * from './tokens/feedback-coefficients';
export * from './tokens/feedforward-coefficients';
export * from './tokens/media-stream';
export * from './tokens/media-stream-track';
export * from './tokens/support';

export * from './types/audio-param-input';
Expand Down
3 changes: 0 additions & 3 deletions libs/audio/src/module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import {WebAudioBufferSource} from './sources/buffer-source';
import {WebAudioConstantSource} from './sources/constant-source';
import {WebAudioMediaSource} from './sources/media-source';
import {WebAudioMediaStreamSource} from './sources/media-stream-source';
import {WebAudioMediaStreamTrackSource} from './sources/media-stream-track-source';
import {WebAudioOscillator} from './sources/oscillator';

@NgModule({
Expand All @@ -42,7 +41,6 @@ import {WebAudioOscillator} from './sources/oscillator';
WebAudioConstantSource,
WebAudioMediaSource,
WebAudioMediaStreamSource,
WebAudioMediaStreamTrackSource,
WebAudioOscillator,
WebAudioAnalyser,
WebAudioBiquadFilter,
Expand Down Expand Up @@ -73,7 +71,6 @@ import {WebAudioOscillator} from './sources/oscillator';
WebAudioConstantSource,
WebAudioMediaSource,
WebAudioMediaStreamSource,
WebAudioMediaStreamTrackSource,
WebAudioOscillator,
WebAudioAnalyser,
WebAudioBiquadFilter,
Expand Down
2 changes: 0 additions & 2 deletions libs/audio/src/polyfill.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,3 @@ windowRef.MediaStreamAudioDestinationNode =
windowRef.MediaStreamAudioDestinationNode || function () {};
windowRef.MediaStreamAudioSourceNode =
windowRef.MediaStreamAudioSourceNode || function () {};
windowRef.MediaStreamTrackAudioSourceNode =
windowRef.MediaStreamTrackAudioSourceNode || function () {};
31 changes: 0 additions & 31 deletions libs/audio/src/sources/media-stream-track-source.ts
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions libs/audio/src/tokens/media-stream-track.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion libs/universal/src/mocks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
global.ConstantSourceNode = class {};
global.MediaElementAudioSourceNode = class {};
global.MediaStreamAudioSourceNode = class {};
global.MediaStreamTrackAudioSourceNode = class {};
global.OscillatorNode = class {};
global.MediaStreamAudioDestinationNode = class {};
global.AnalyserNode = class {};
Expand Down