Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/cache from 3 to 4 #3

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Feb 5, 2024

Bumps actions/cache from 3 to 4.

Release notes

Sourced from actions/cache's releases.

v4.0.0

What's Changed

New Contributors

Full Changelog: actions/cache@v3...v4.0.0

v3.3.3

What's Changed

New Contributors

Full Changelog: actions/cache@v3...v3.3.3

v3.3.2

What's Changed

New Contributors

Full Changelog: actions/cache@v3...v3.3.2

v3.3.1

What's Changed

Full Changelog: actions/cache@v3...v3.3.1

v3.3.0

What's Changed

... (truncated)

Changelog

Sourced from actions/cache's changelog.

Releases

3.0.0

  • Updated minimum runner version support from node 12 -> node 16

3.0.1

  • Added support for caching from GHES 3.5.
  • Fixed download issue for files > 2GB during restore.

3.0.2

  • Added support for dynamic cache size cap on GHES.

3.0.3

  • Fixed avoiding empty cache save when no files are available for caching. (issue)

3.0.4

  • Fixed tar creation error while trying to create tar with path as ~/ home folder on ubuntu-latest. (issue)

3.0.5

  • Removed error handling by consuming actions/cache 3.0 toolkit, Now cache server error handling will be done by toolkit. (PR)

3.0.6

  • Fixed #809 - zstd -d: no such file or directory error
  • Fixed #833 - cache doesn't work with github workspace directory

3.0.7

  • Fixed #810 - download stuck issue. A new timeout is introduced in the download process to abort the download if it gets stuck and doesn't finish within an hour.

3.0.8

  • Fix zstd not working for windows on gnu tar in issues #888 and #891.
  • Allowing users to provide a custom timeout as input for aborting download of a cache segment using an environment variable SEGMENT_DOWNLOAD_TIMEOUT_MINS. Default is 60 minutes.

3.0.9

  • Enhanced the warning message for cache unavailablity in case of GHES.

3.0.10

  • Fix a bug with sorting inputs.
  • Update definition for restore-keys in README.md

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@taiki-e
Copy link
Owner

taiki-e commented Feb 5, 2024

# TODO: currently, we cannot update to v4 because node20 doesn't work on CentOS 7: https://github.com/actions/runner/issues/2906
uses: actions/cache@v3

@daxpedda
Copy link

daxpedda commented Mar 7, 2024

Node v16 won't be available anymore from 13th of May.
https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Another point is that its saying its removing "Action runner support" (does that mean all actions?) from CentOS 7, because it does indeed not support Node v20.

@taiki-e
Copy link
Owner

taiki-e commented Mar 11, 2024

The problem is they are trying to do it in a way that breaks compatibility. And since a reasonable solution to fix the compatibility problem has been proposed by the community (although GitHub is ignoring it at this time), it is difficult to determine whether it is reasonable to make users go through the hassle of updating by dropping support for CentOS 7, etc. at this time.

This problem has been bugging me for several months now, and the solution I took for the actions/checkout case was to simply move away from nodejs-based action (i.e., actions/checkout). checkout-action / 1b5dc9d / 4b826a9
Of course, actions/cache is more complex than actions/checkout so I'm not sure if I can do the same thing, but I will at least try to see if it can be done.

@taiki-e
Copy link
Owner

taiki-e commented Apr 26, 2024

Unfortunately, I did not have time to investigate alternative implementations of actions/cache, so I will bump actions/cache to 4, treat it as a breaking change, and release it in v2.

@taiki-e taiki-e force-pushed the dependabot/github_actions/actions/cache-4 branch from 35dd3e1 to 3e59159 Compare April 26, 2024 08:30
@taiki-e taiki-e merged commit 0ba1a6b into main Apr 26, 2024
21 checks passed
@taiki-e taiki-e deleted the dependabot/github_actions/actions/cache-4 branch April 26, 2024 08:34
@taiki-e
Copy link
Owner

taiki-e commented Apr 26, 2024

Published in 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants