Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): prevent oracle prover overriding the same proof #13681

Merged
merged 18 commits into from
May 3, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 29, 2023

  1. I think we should prevent oracle prover to override the same fork choice as implemented.
  2. Cooldown period is disabled if:
    • The oracle prover is address(0)
    • The oracle prover proves blocks that doesn't need real ZKPs.

Tests will need to be added (tracked by #13686)

Base automatically changed from protocol_simulation to major_protocol_upgrade_alpha3 April 29, 2023 10:53
@dantaik
Copy link
Contributor Author

dantaik commented Apr 29, 2023

@adaki2004 maybe we should ignore all the simulation output files (png and other files)? For those we want to include, use git add -f somefile

@adaki2004
Copy link
Contributor

@adaki2004 maybe we should ignore out the simulation out file files (png and other files)?

Hmm, def. not include all, just maybe having some there as a demonstration/benchmark , or at least ppl who try to run, knows how the output looks like. (?).
1 sample shall be enough i guess.

@dantaik dantaik merged commit 029ba8c into major_protocol_upgrade_alpha3 May 3, 2023
@dantaik dantaik deleted the cannot_override_same_proof branch May 3, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants