refactor(protocol): optimize core protocol and bridge implementation #14310

adaki2004 · 2023-07-28T14:12:04Z

Inspired by Brecht's feature request, this PR aims to separate the current prover (pool) contract from the core protocol, allowing various prover contract designs. Taiko will act as the "glue" between the core protocol and different prover contracts.

Core protocol Changes introduced in this PR:

Block Proposal: Blocks must assign a non-zero prover address, and proposers will pay a non-refundable Ether fee to the prover. The prover will burn Taiko tokens as a bond, returned if proof is submitted within 90 minutes; otherwise, the block opens, and half the bond goes to the actual prover.
Prover Authorization: If an EOA, must authorize the proposer with a valid ECDSA signature; if a contract, must have a onBlockAssigned function that doesn't revert.
Notification Calls: Removed on-chain notification calls to prover (pool) contract to prevent malicious exploitation.
Prover (Pool) Contract and API: Deleted IProverPool. Taiko and partners will create a Pool API server for proposers to access proving services.
Token and Configuration: Taiko token supply won't increase; decimals are set to 18. TaikoConfig is simplified, loaded from a Library for testing.
@davidtaikocha @smtmfft I added two TODOs for you in this PR.

Taiko Token functions as a bond token for provers.

Bridge changes introduced in this PR:

Introduced a recallMessage on the source bridge, it will call the message.from to perform custom recall function. (Releasing Ether is no longer handled by the bridge, but the message's from contract.
Implemented all optimizations captured in this issue: A few Bridge improvement ideas #14384
Added NFT vaults

Co-authored-by: D <51912515+adaki2004@users.noreply.github.com> Co-authored-by: dantaik <dantaik@users.noreply.github.com> Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com> Co-authored-by: adaki2004 <adaki2004@users.noreply.github.com> Co-authored-by: jeff <113397187+cyberhorsey@users.noreply.github.com> Co-authored-by: Francisco Ramos <jscriptcoder@gmail.com> Co-authored-by: David <david@taiko.xyz> Co-authored-by: Kenk <kenghin_lim@hotmail.com> Co-authored-by: mfinestone <36642873+mfinestone@users.noreply.github.com> Co-authored-by: hideonbug <92258181+whohideonbug@users.noreply.github.com> Co-authored-by: megumii <98658943+Megumiiiiii@users.noreply.github.com> Co-authored-by: Tomaž <venooxpersonal@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Daniel Wang <dong77@gmail.com> Co-authored-by: adaki2004 <keszeydani@gmail.com> Co-authored-by: Jeffery Walsh <cyberhorsey@gmail.com> Co-authored-by: cyberhorsey <cyberhorsey@users.noreply.github.com> Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>

Co-authored-by: dantaik <dantaik@users.noreply.github.com> Co-authored-by: Jeffery Walsh <cyberhorsey@gmail.com> Co-authored-by: cyberhorsey <cyberhorsey@users.noreply.github.com>

…14075)

… deployonl1 script (#14084)

)

…roofs (#14097)

Co-authored-by: dantaik <dantaik@users.noreply.github.com> Co-authored-by: Daniel Wang <dong77@gmail.com>

…4103)

Co-authored-by: Daniel Wang <dong77@gmail.com> Co-authored-by: jeff <113397187+cyberhorsey@users.noreply.github.com>

Co-authored-by: Daniel Wang <dong77@gmail.com>

…otocol (#14541) Co-authored-by: adaki2004 <keszeydani@gmail.com> Co-authored-by: David <david@taiko.xyz> Co-authored-by: Jeffery Walsh <cyberhorsey@gmail.com> Co-authored-by: D <51912515+adaki2004@users.noreply.github.com>

dantaik · 2023-08-27T13:54:15Z

@Brechtpd @davidtaikocha @cyberhorsey please approve this PR again -- I just merge the core protocol optimization PR into this one.

dantaik and others added 30 commits June 28, 2023 15:30

refactor(protocol): add very minor update (#14066)

c7fee73

refactor(protocol): optimize ProverPool (#14069)

4cb7367

Co-authored-by: dantaik <dantaik@users.noreply.github.com> Co-authored-by: Jeffery Walsh <cyberhorsey@gmail.com> Co-authored-by: cyberhorsey <cyberhorsey@users.noreply.github.com>

Merge branch 'main' into alpha-4

dc2e975

fix(protocol): Fix alpha-4 ability to build protocol and run tests (#…

46c0e66

…14075)

feat(eventindexer): Alpha 4 event indexing (#14078)

dee55c9

feat(relayer): Alpha 4 event sub (#14081)

5c40c12

Merge branch 'main' into alpha-4

81176e3

chore(protocol): delete ProverPool2 and deprecated documents (#14082)

8e398f4

feat(protocol): allow premint of TKO to multiple addresses/amounts in…

478ba5e

… deployonl1 script (#14084)

chore(protocol): use block.prevrandao to avoid warning (#14088)

8ba71a6

Merge branch 'main' into alpha-4

6805a11

Update TokenVault.sol

e8ffbb8

fix typo

2fa83d2

feat(protocol): restrict prover staking changes to once per hour (#14093

a539646

)

feat(protocol): disable oracle proofs to be over written by regular p…

5bf313e

…roofs (#14097)

feat(protocol): unify taiko tokens acros L1, L2s, and L3s (#14083)

38d537b

Co-authored-by: dantaik <dantaik@users.noreply.github.com> Co-authored-by: Daniel Wang <dong77@gmail.com>

Merge branch 'main' into alpha-4

4e8e78a

feat(protocol): A4 bindings (#14101)

7f41353

fix(eventindexer): add address to Slashed event in db, + add logs (#1…

4ef8d0c

…4103)

fix(protocol): limit reward per gas in weight calculation (#14098)

05da0e7

Co-authored-by: Daniel Wang <dong77@gmail.com> Co-authored-by: jeff <113397187+cyberhorsey@users.noreply.github.com>

add provers route

c341f0a

Merge branch 'main' into alpha-4

44d119e

abigen

a24f9a6

Merge branch 'alpha-4' of github.com:taikoxyz/taiko-mono into alpha-4

76d9375

chore(protocol) use uint32 for gas limit, gas used, gas price (#14112)

5cd6c82

feat(protocol): add prover into block events (#14123)

fd07f3f

Co-authored-by: Daniel Wang <dong77@gmail.com>

feat(protocol): also add rewardPerGas into BlockProposedEvent (#14124)

c4c671e

Co-authored-by: Daniel Wang <dong77@gmail.com>

Resolve merge from main with eventindexer changes

053e198

Merge branch 'alpha-4' of github.com:taikoxyz/taiko-mono into alpha-4

c4ab00d

vercel bot deployed to Preview – bridge-ui-v2 August 26, 2023 03:54 View deployment

vercel bot deployed to Preview – bridge-ui-l3 August 26, 2023 03:55 View deployment

vercel bot deployed to Preview – geth-diff August 26, 2023 03:55 View deployment

dantaik requested review from Brechtpd and dantaik August 26, 2023 03:56

dantaik previously approved these changes Aug 26, 2023

View reviewed changes

dantaik removed request for jscriptcoder, KorbinianK, xiaodino and cyberhorsey August 26, 2023 03:56

vercel bot deployed to Preview – website August 26, 2023 03:57 View deployment

Brechtpd previously approved these changes Aug 26, 2023

View reviewed changes

dantaik dismissed stale reviews from Brechtpd and themself via 001b722 August 27, 2023 13:51

dantaik changed the title ~~refactor(protocol): optimize bridge with recallMessage and other simplifications~~ refactor(protocol): optimize core protocol and bridge implementation Aug 27, 2023

Merge branch 'main' into one_txn_token_and_eth_release

f6ec18d

dantaik requested review from dantaik and Brechtpd August 27, 2023 13:53

dantaik enabled auto-merge August 27, 2023 13:54

dantaik approved these changes Aug 27, 2023

View reviewed changes

dantaik added the meta.alpha-5 label Aug 27, 2023

vercel bot deployed to Preview – bridge-ui-l3 August 27, 2023 13:57 View deployment

vercel bot deployed to Preview – website August 27, 2023 13:59 View deployment

dantaik added this pull request to the merge queue Aug 27, 2023

davidtaikocha approved these changes Aug 27, 2023

View reviewed changes

Merged via the queue into main with commit 437763a Aug 27, 2023
17 of 18 checks passed

dantaik deleted the one_txn_token_and_eth_release branch August 27, 2023 14:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(protocol): optimize core protocol and bridge implementation #14310

refactor(protocol): optimize core protocol and bridge implementation #14310

adaki2004 commented Jul 28, 2023 •

edited by dantaik

Loading

dantaik commented Aug 27, 2023

refactor(protocol): optimize core protocol and bridge implementation #14310

refactor(protocol): optimize core protocol and bridge implementation #14310

Conversation

adaki2004 commented Jul 28, 2023 • edited by dantaik Loading

dantaik commented Aug 27, 2023

adaki2004 commented Jul 28, 2023 •

edited by dantaik

Loading