-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): simplify protocol and remove prover pool from core protocol #14541
Merged
dantaik
merged 29 commits into
one_txn_token_and_eth_release
from
prover_abstraction_and_protocol_simplification
Aug 27, 2023
Merged
feat(protocol): simplify protocol and remove prover pool from core protocol #14541
dantaik
merged 29 commits into
one_txn_token_and_eth_release
from
prover_abstraction_and_protocol_simplification
Aug 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: adaki2004 <keszeydani@gmail.com> Co-authored-by: David <david@taiko.xyz>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dantaik
requested review from
adaki2004,
d1onys1us,
Brechtpd,
davidtaikocha and
cyberhorsey
August 19, 2023 15:58
dantaik
changed the title
feat(protocol): simplify protocol and remove prover from core protocol
feat(protocol): simplify protocol and remove prover pool from core protocol
Aug 21, 2023
joohhnnn
reviewed
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it would be more appropriate to replace the public keyword with external? Can slightly reduce some gas
davidtaikocha
approved these changes
Aug 21, 2023
dantaik
requested review from
joohhnnn
and removed request for
d1onys1us,
joohhnnn and
cyberhorsey
August 26, 2023 03:56
…and_protocol_simplification
Brechtpd
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by Brecht's feature request, this PR aims to separate the current prover (pool) contract from the core protocol, allowing various prover contract designs. Taiko will act as the "glue" between the core protocol and different prover contracts.
Changes introduced in this PR:
onBlockAssigned
function that doesn't revert.Taiko Token functions as a bond token for provers.