-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for writing to nwb with ndx-pose > 0.2.0 #143
base: main
Are you sure you want to change the base?
Add support for writing to nwb with ndx-pose > 0.2.0 #143
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
==========================================
- Coverage 96.21% 96.14% -0.08%
==========================================
Files 17 17
Lines 2327 2362 +35
==========================================
+ Hits 2239 2271 +32
- Misses 88 91 +3 ☔ View full report in Codecov by Sentry. |
OK, all tests passed but the windows job was canceled for some reason. I will check the coverage once I know from you guys if you think it is a good idea to separate this from #104. |
This adds support for the ndx-pose > 0.2.0 for structures such as
PoseEstimationSeries
,PoseEstimation
and the newly introduced "Skeleton" and "Skeletons" container.I am aware that there is larger effort to use the training related structure of ndx-pose > 0.2.0 on #104 but I thought this effort could be divided (and that way the PR simplified) into a PR for post-training structures (this) and one for the training structures (#104).
Let me know what you think.