-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default callable for match_lists_function
#1520
Set default callable for match_lists_function
#1520
Conversation
WalkthroughThe changes primarily focus on refactoring the Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Files selected for processing (2)
- sleap/info/metrics.py (3 hunks)
- tests/info/test_metrics.py (1 hunks)
Files skipped from review due to trivial changes (1)
- sleap/info/metrics.py
Codecov Report
@@ Coverage Diff @@
## develop #1520 +/- ##
===========================================
+ Coverage 73.11% 73.39% +0.27%
===========================================
Files 134 134
Lines 23972 23961 -11
===========================================
+ Hits 17528 17586 +58
+ Misses 6444 6375 -69
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Set the default value for the argument
match_lists_function
tomatch_instance_lists_nodewise
in the helper functionmatched_instance_distances
(which is not used in the package code).Types of changes
Does this address any currently open issues?
Outside contributors checklist
Thank you for contributing to SLEAP!
❤️
Summary by CodeRabbit
sleap/info/metrics.py
, the functionmatched_instance_distances
has been repositioned and its default value formatch_lists_function
parameter has been updated to improve code readability and maintainability.test_matched_instance_distances
intests/info/test_metrics.py
. This function validates the accuracy of distance calculations between nodes in two sets of labels, enhancing the robustness of our testing suite.