You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AddInstance command has a long and confusing do_action method. This PR makes no logical changes and just organizes the do_action method into its subparts.
Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
Add tests that prove your fix is effective or that your feature works
Add necessary documentation (if appropriate)
Thank you for contributing to SLEAP!
❤️
Summary by CodeRabbit
Refactor: The "Add Instance" feature in the SLEAP GUI has been improved for better performance and reliability. This update enhances the process of creating a new instance and filling missing nodes, making it more efficient and user-friendly. The changes are not directly visible to the end-user but contribute to a smoother, more responsive user experience.
The changes primarily focus on the sleap/gui/commands.py file, enhancing its readability and maintainability. The AddInstance class has been refactored, with several methods extracted for better modularity. Unused imports and unnecessary empty lines have been removed, contributing to a cleaner and more organized codebase.
Changes
File
Summary
.../gui/commands.py
Unused imports and empty lines have been removed. The AddInstance class has been refactored for improved readability and maintainability. Several methods have been extracted for better modularity, and the get_previous_frame_index method has been moved to the AddInstance class.
🐇
"In the land of code, where the shadows lie,
Refactoring reigns, under the cloudless sky.
Unused imports banished, empty lines no more,
The rabbit hops along, leaving folklore.
With every hop and skip, the code becomes clear,
Celebrate the changes, for the end is near!" 🎉
Tips
Chat with CodeRabbit Bot (@coderabbitai)
Mention @coderabbitai in any review comment for bot assistance.
Note: Review comments are made on code diffs or files, not on the PR overview.
Pause Incremental Reviews
Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
resume reviews, enter @coderabbitai resume as any issue or review comment.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Description
The
AddInstancecommand has a long and confusingdo_actionmethod. This PR makes no logical changes and just organizes thedo_actionmethod into its subparts.Types of changes
Does this address any currently open issues?
[list open issues here]
Outside contributors checklist
Thank you for contributing to SLEAP!
❤️
Summary by CodeRabbit