-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change inference pipeline option to tracking-only #1666
change inference pipeline option to tracking-only #1666
Conversation
Important Auto Review SkippedReview was skipped due to path filters Files ignored due to path filters (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1666 +/- ##
===========================================
- Coverage 73.38% 73.38% -0.01%
===========================================
Files 134 134
Lines 24064 24064
===========================================
- Hits 17660 17659 -1
- Misses 6404 6405 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Also verified that re-tracking works and found why (do to the current_pipeline
property:
sleap/sleap/gui/learning/dialog.py
Lines 948 to 963 in 14b5b78
@property | |
def current_pipeline(self): | |
pipeline_selected_label = self.pipeline_field.value() | |
if "top-down" in pipeline_selected_label: | |
if "id" not in pipeline_selected_label: | |
return "top-down" | |
else: | |
return "top-down-id" | |
if "bottom-up" in pipeline_selected_label: | |
if "id" not in pipeline_selected_label: | |
return "bottom-up" | |
else: | |
return "bottom-up-id" | |
if "single" in pipeline_selected_label: | |
return "single" | |
return "" |
that always sets the
current_pipeline
to ""
if it is not one of the model types).
Description
The option
none
might not be clear while trying to choose the type of pipeline. Hence changing it totracking-only
to make it clear if you just want to rerun the tracker (for non-id models) without running inference.Types of changes
Does this address any currently open issues?
Outside contributors checklist
Thank you for contributing to SLEAP!
❤️