Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change inference pipeline option to tracking-only #1666

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

shrivaths16
Copy link
Contributor

@shrivaths16 shrivaths16 commented Jan 19, 2024

Description

The option none might not be clear while trying to choose the type of pipeline. Hence changing it to tracking-only to make it clear if you just want to rerun the tracker (for non-id models) without running inference.

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (explain)

Does this address any currently open issues?

Outside contributors checklist

  • Review the guidelines for contributing to this repository
  • Read and sign the CLA and add yourself to the authors list
  • Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
  • Add tests that prove your fix is effective or that your feature works
  • Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

❤️

Copy link

coderabbitai bot commented Jan 19, 2024

Important

Auto Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (1)
  • sleap/config/pipeline_form.yaml is excluded by: !**/*.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14b5b78) 73.38% compared to head (e929472) 73.38%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1666      +/-   ##
===========================================
- Coverage    73.38%   73.38%   -0.01%     
===========================================
  Files          134      134              
  Lines        24064    24064              
===========================================
- Hits         17660    17659       -1     
- Misses        6404     6405       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shrivaths16 shrivaths16 changed the title changinference option to tracking-only change inference pipeline option to tracking-only Jan 20, 2024
@shrivaths16 shrivaths16 marked this pull request as ready for review January 22, 2024 20:03
Copy link
Collaborator

@roomrys roomrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Also verified that re-tracking works and found why (do to the current_pipeline property:

@property
def current_pipeline(self):
pipeline_selected_label = self.pipeline_field.value()
if "top-down" in pipeline_selected_label:
if "id" not in pipeline_selected_label:
return "top-down"
else:
return "top-down-id"
if "bottom-up" in pipeline_selected_label:
if "id" not in pipeline_selected_label:
return "bottom-up"
else:
return "bottom-up-id"
if "single" in pipeline_selected_label:
return "single"
return ""

that always sets the current_pipeline to "" if it is not one of the model types).

@shrivaths16 shrivaths16 linked an issue Jan 23, 2024 that may be closed by this pull request
@shrivaths16 shrivaths16 merged commit 60a441f into develop Jan 23, 2024
9 checks passed
@roomrys roomrys deleted the shrivaths/inference-pipeline-none-option-fix branch August 24, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None option under training pipeline
2 participants