Update to new TensorFlow conda package #1726
Conversation
|
Warning Rate Limit Exceeded@talmo has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 9 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe changes made across various files aim to enhance compatibility, update dependencies, and refine functionality. These adjustments include modifying dependencies, updating version constraints, and refining scripts to address potential issues and improve the overall build and runtime environment. Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files ignored due to path filters (3)
environment.ymlis excluded by!**/*.ymlenvironment_mac.ymlis excluded by!**/*.ymlenvironment_no_cuda.ymlis excluded by!**/*.yml
Files selected for processing (7)
- .conda/bld.bat (1 hunks)
- .conda/build.sh (1 hunks)
- .conda/meta.yaml (2 hunks)
- pypi_requirements.txt (2 hunks)
- requirements.txt (2 hunks)
- sleap/nn/data/augmentation.py (1 hunks)
- tests/nn/data/test_augmentation.py (3 hunks)
Additional Context Used
Additional comments not posted (7)
.conda/bld.bat (1)
10-10: Removing the--no-binary qudida,albumentationsoption from thepip installcommand will allowpipto use binary distributions for these packages if available. This can lead to faster installations and potentially avoid compilation issues. However, it's recommended to add a comment explaining this change for the benefit of future maintainers.requirements.txt (1)
2-7: > 📝 NOTEThis review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-14]
The changes to
requirements.txt, including the removal ofndx-poseandalbumentationsand updates to version constraints for several packages, appear to be aimed at ensuring compatibility with TensorFlow 2.7.4. It's important to verify that these changes do not introduce conflicts with other dependencies and align with the project's requirements..conda/build.sh (1)
10-10: Removing the--no-binary qudida,albumentationsoption from thepip installcommand will allowpipto use binary distributions for these packages if available. It's recommended to add a shebang (e.g.,#!/bin/bash) at the top of the script for clarity and a comment explaining this change for the benefit of future maintainers.pypi_requirements.txt (1)
3-17: > 📝 NOTEThis review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [6-38]
The updates to
pypi_requirements.txt, including the introduction of new dependencies likealbumentationsandndx-poseand adjustments to version constraints for several packages, appear to be aimed at ensuring compatibility with TensorFlow 2.7.4. It's important to verify that these changes do not introduce conflicts with other dependencies and align with the project's requirements..conda/meta.yaml (1)
55-57: Adding new dependenciesqudida,albumentations, andndx-poseto bothrequirementsandrunsections in the.conda/meta.yamlfile appears to be aimed at managing these dependencies through conda, possibly for compatibility with TensorFlow 2.7.4. It's important to verify that these additions do not introduce version conflicts and are compatible with the project's requirements.Also applies to: 88-90
tests/nn/data/test_augmentation.py (1)
1-1: The addition of import statements, fixtures for dummy data and augmentation configuration, and tests for the AlbumentationsAugmenter class intests/nn/data/test_augmentation.pyenhances test coverage and ensures the correctness of data augmentation functionalities. The use of fixtures is commendable for organizing test data and making tests more readable and maintainable.Also applies to: 13-63, 66-92, 144-168
sleap/nn/data/augmentation.py (1)
198-199: Addingremove_invisible=Falseto theA.KeypointParamsdeclaration in theAlbumentationsAugmenterensures that keypoints marked as invisible are not removed during the augmentation process. This change is commendable for preserving the integrity of keypoint data, which is crucial for tasks that rely on keypoints.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1726 +/- ##
========================================
Coverage 73.30% 73.31%
========================================
Files 134 134
Lines 24087 24087
========================================
+ Hits 17658 17659 +1
+ Misses 6429 6428 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (4)
- .conda/meta.yaml (3 hunks)
- environment.yml (1 hunks)
- environment_no_cuda.yml (1 hunks)
- requirements.txt (1 hunks)
Additional comments not posted (5)
requirements.txt (1)
12-12: Clarify the commented-outh5pyversion constraint.Consider updating the comment to explain the resolution for Linux environments and confirm that this change does not inadvertently affect Windows users.
environment_no_cuda.yml (1)
38-39: Update TensorFlow to version 2.7.0 for compatibility.Ensure compatibility with other dependencies.
environment.yml (1)
37-38: Update TensorFlow to version 2.7.0 for GPU support.Verify compatibility with CUDA and GPU-related dependencies.
.conda/meta.yaml (2)
35-36: Updateh5pyto version 3.7.0.Ensure compatibility with other dependencies.
Also applies to: 66-67
88-89: Update TensorFlow to version 2.7.0.Verify compatibility with TensorFlow's ecosystem.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (2)
- .conda/meta.yaml (4 hunks)
- sleap/version.py (1 hunks)
Files skipped from review due to trivial changes (1)
- sleap/version.py
Files skipped from review as they are similar to previous changes (1)
- .conda/meta.yaml
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (4)
- .conda_mac/meta.yaml (3 hunks)
- .github/workflows/build.yml (4 hunks)
- .github/workflows/ci.yml (1 hunks)
- environment_mac.yml (2 hunks)
Additional comments not posted (8)
environment_mac.yml (3)
12-12: Addedimportlib-metadatawith a version constraint. Ensure this version is compatible with other dependencies.
18-18: Updatednetworkxversion constraint to<3.3. Consider adding a comment explaining the reason for this specific version constraint for future reference.
38-38: Commented outtensorflow-hub. Verify if it's not required for TensorFlow 2.7.0 or if an alternative is needed..conda_mac/meta.yaml (3)
19-19: Adjusted the build number to 0, indicating a new series of builds. This is a standard practice and is approved.
57-59: Added new dependenciesqudida,albumentations, andndx-pose. Ensure these are compatible with TensorFlow 2.7.0 and other dependencies.
87-87: Commented outtensorflow-hub. Document the reason for this decision to aid future maintenance and clarity..github/workflows/ci.yml (1)
68-68: Updated the macOS version in the matrix configuration tomacos-14. Ensure compatibility with all dependencies and the application..github/workflows/build.yml (1)
16-16: Updated the macOS version in the matrix configuration tomacos-14. Recommend thorough testing to ensure seamless build processes on the new OS version.
…ion-in-conda-package' into elizabeth/change-TensorFlow-version-in-conda-package
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (2)
- .conda_mac/meta.yaml (5 hunks)
- requirements.txt (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- .conda_mac/meta.yaml
- requirements.txt
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (3)
- .conda/meta.yaml (4 hunks)
- environment.yml (2 hunks)
- environment_no_cuda.yml (2 hunks)
Files skipped from review as they are similar to previous changes (3)
- .conda/meta.yaml
- environment.yml
- environment_no_cuda.yml
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (2)
- .github/workflows/build.yml (4 hunks)
- .github/workflows/build_manual.yml (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/build.yml
Additional comments not posted (5)
.github/workflows/build_manual.yml (5)
21-21: Updating the macOS version to "macos-14" in the matrix is a good move for ensuring compatibility with the specified TensorFlow version.
27-27: Using a macOS-specificcondarcfile is a prudent choice for handling macOS-specific build configurations.
87-87: The conditional build step for macOS, using the.conda_macdirectory, is appropriate for handling platform-specific requirements.
112-112: The conditional login step for macOS aligns with the platform-specific configurations introduced earlier in the workflow.
135-138: The conditional upload step for macOS, targetingosx-arm64, ensures that macOS-specific packages are correctly handled.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (7)
- .conda/condarc.yaml (1 hunks)
- .conda/meta.yaml (4 hunks)
- .github/workflows/build.yml (4 hunks)
- .github/workflows/build_manual.yml (5 hunks)
- .github/workflows/ci.yml (1 hunks)
- environment.yml (2 hunks)
- requirements.txt (1 hunks)
Files skipped from review as they are similar to previous changes (6)
- .conda/meta.yaml
- .github/workflows/build.yml
- .github/workflows/build_manual.yml
- .github/workflows/ci.yml
- environment.yml
- requirements.txt
Additional comments not posted (1)
.conda/condarc.yaml (1)
4-4: The addition of a commented-outsleapchannel link is noted. Ensure this aligns with the project's dependency management strategy and consider documenting the conditions under which it should be enabled.
talmo
changed the title
Description
Notes:
sleap/label/devuntil the new TensorFlow v2.7.0 package is moved over tomain(this will break v1.3.3 installs)Types of changes
Does this address any currently open issues?
#1721
Outside contributors checklist
Thank you for contributing to SLEAP!
❤️
Summary by CodeRabbit
qudida,albumentations, andndx-poseto enhance functionality.opencv-python,tensorflow, and others to ensure compatibility and performance.uniform_noisefunction and adding relevant tests.