Don't throw when native pointers have long values < 0 (#2217)

* Don't throw when native pointers have long values < 0 Android 11 and certain ROMs use "tagged pointers" that set the high bits on pointers, causing them to become negative as a long. * Fix more pointer check comparisons in MapController
tangrams · Dec 14, 2020 · 434f27a · 434f27a
1 parent 589667e
commit 434f27a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 12 deletions.
diff --git a/platforms/android/tangram/src/main/java/com/mapzen/tangram/MapController.java b/platforms/android/tangram/src/main/java/com/mapzen/tangram/MapController.java
@@ -670,7 +670,7 @@ public MapData addDataLayer(final String name, final boolean generateCentroid) {
             return mapData;
         }
         final long pointer = nativeMap.addClientDataSource(name, generateCentroid);
-        if (pointer <= 0) {
+        if (pointer == 0) {
             throw new RuntimeException("Unable to create new data source");
         }
         mapData = new MapData(name, pointer, this);
@@ -684,7 +684,9 @@ public MapData addDataLayer(final String name, final boolean generateCentroid) {
      */
     void removeDataLayer(@NonNull final MapData mapData) {
         clientTileSources.remove(mapData.name);
-        checkPointer(mapData.pointer);
+        if (mapData.pointer == 0) {
+            throw new RuntimeException("Tried to remove a MapData that was already disposed");
+        }
         nativeMap.removeClientDataSource(mapData.pointer);
     }
 
@@ -1083,14 +1085,6 @@ void onLowMemory() {
         nativeMap.onLowMemory();
     }
 
-    void checkPointer(final long ptr) {
-        if (ptr <= 0) {
-            throw new RuntimeException("Tried to perform an operation on an invalid pointer!"
-                    + " This means you may have used an object that has been disposed and is no"
-                    + " longer valid.");
-        }
-    }
-
     void checkId(final long id) {
         if (id <= 0) {
             throw new RuntimeException("Tried to perform an operation on an invalid id!"

diff --git a/platforms/android/tangram/src/main/java/com/mapzen/tangram/MapData.java b/platforms/android/tangram/src/main/java/com/mapzen/tangram/MapData.java
@@ -92,7 +92,7 @@ public void clear() {
     }
 
     private void checkPointer(final long ptr) {
-        if (ptr <= 0) {
+        if (ptr == 0) {
             throw new RuntimeException("Tried to perform an operation on an invalid pointer!"
                     + " This means you may have used a MapData that has already been removed.");
         }

diff --git a/platforms/android/tangram/src/main/java/com/mapzen/tangram/NativeMap.java b/platforms/android/tangram/src/main/java/com/mapzen/tangram/NativeMap.java
@@ -9,7 +9,7 @@ class NativeMap {
 
     NativeMap(MapController mapController, AssetManager assetManager) {
         nativePointer = init(mapController, assetManager);
-        if (nativePointer <= 0) {
+        if (nativePointer == 0) {
             throw new RuntimeException("Unable to create a native Map object! There may be insufficient memory available.");
         }
     }