Don't throw when native pointers have long values < 0 #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android 11 and certain ROMs use "tagged pointers" that set the high bits on pointers, causing them to become negative as a long.
bcamper
reviewed
Dec 10, 2020
| @@ -670,7 +670,7 @@ public MapData addDataLayer(final String name, final boolean generateCentroid) { | |||
| return mapData; | |||
| } | |||
| final long pointer = nativeMap.addClientDataSource(name, generateCentroid); | |||
| if (pointer <= 0) { | |||
| if (pointer == 0) { | |||
There was a problem hiding this comment.
Not to be pedantic, but wouldn't it clarify intention here if it was just pointer == NULL? e.g. pointer <= NULL wouldn't have made sense to a casual reader.
There was a problem hiding this comment.
Oh this is Java not C++ code here... maybe that matters.
There was a problem hiding this comment.
Yep, Java's null is not the same as NULL in C/C++ and it can't be compared with a long.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android 11 and certain ROMs use "tagged pointers" that set the high bits on pointers, causing them to become negative as a long.
See #2215