Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update constraints and foreign keys docs #3583

Merged
merged 8 commits into from
Jul 19, 2023
Merged

Update constraints and foreign keys docs #3583

merged 8 commits into from
Jul 19, 2023

Conversation

p7nov
Copy link
Contributor

@p7nov p7nov commented Jul 17, 2023

Resolves #3043, #3360, #3361, #3429

@p7nov p7nov force-pushed the gh-3043-constraints branch 4 times, most recently from 3c181ca to d77a1a8 Compare July 18, 2023 05:07
Copy link
Contributor

@andreyaksenov andreyaksenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added several small suggestions.

doc/code_snippets/test/constraints/constraint_test.lua Outdated Show resolved Hide resolved
function() customers:insert{2, "Bob", 230} end)

box.schema.func.create('another_constraint',
{language = 'LUA', is_deterministic = true, body = 'function(t, c) return (t.age >= 0 and #(t.name) > 3) end'})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, include this code to docs to understand where another_constraint is taken from?

doc/concepts/data_model/value_store.rst Outdated Show resolved Hide resolved
doc/concepts/data_model/value_store.rst Outdated Show resolved Hide resolved
doc/code_snippets/test/constraints/constraint_test.lua Outdated Show resolved Hide resolved
doc/reference/reference_lua/box_schema/space_create.rst Outdated Show resolved Hide resolved
doc/reference/reference_lua/box_schema/space_create.rst Outdated Show resolved Hide resolved
doc/reference/reference_lua/box_schema/space_create.rst Outdated Show resolved Hide resolved
doc/reference/reference_lua/box_schema/space_create.rst Outdated Show resolved Hide resolved
doc/reference/reference_lua/box_schema/space_create.rst Outdated Show resolved Hide resolved
p7nov and others added 4 commits July 19, 2023 11:39
Co-authored-by: Andrey Aksenov <38073144+andreyaksenov@users.noreply.github.com>
@p7nov p7nov merged commit b0c3a30 into latest Jul 19, 2023
1 check passed
@p7nov p7nov deleted the gh-3043-constraints branch July 19, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Describe foreign keys referring to the same space
4 participants