-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update constraints and foreign keys docs #3583
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p7nov
force-pushed
the
gh-3043-constraints
branch
from
July 17, 2023 05:46
291a172
to
80b6c38
Compare
p7nov
force-pushed
the
gh-3043-constraints
branch
4 times, most recently
from
July 18, 2023 05:07
3c181ca
to
d77a1a8
Compare
p7nov
force-pushed
the
gh-3043-constraints
branch
from
July 18, 2023 05:41
d77a1a8
to
cd521e5
Compare
ImeevMA
approved these changes
Jul 18, 2023
p7nov
force-pushed
the
gh-3043-constraints
branch
from
July 18, 2023 08:32
286f1af
to
2f893c8
Compare
Gumix
approved these changes
Jul 18, 2023
p7nov
force-pushed
the
gh-3043-constraints
branch
from
July 18, 2023 10:39
2f893c8
to
0655249
Compare
andreyaksenov
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added several small suggestions.
function() customers:insert{2, "Bob", 230} end) | ||
|
||
box.schema.func.create('another_constraint', | ||
{language = 'LUA', is_deterministic = true, body = 'function(t, c) return (t.age >= 0 and #(t.name) > 3) end'}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, include this code to docs to understand where another_constraint
is taken from?
Co-authored-by: Andrey Aksenov <38073144+andreyaksenov@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3043, #3360, #3361, #3429
constraint
andforeign_key
parameters to reference pages of space_create and space.formatliteralinclude
.