Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update constraints and foreign keys docs #3583
Update constraints and foreign keys docs #3583
Changes from 4 commits
80b6c38
054926a
cd521e5
0655249
0fb6131
1939a92
e2aac99
0f86a83
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, include this code to docs to understand where
another_constraint
is taken from?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd include the index creation here - copying and pasting this sample causes an error now:
error: 'No index #0 is defined in space ''orders''
. Maybe, it's worth including the code showing how to create thecustomers
space.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including the index without the parent space creation and formatting doesn't make this snippet copy-pastable.
On the other hand, including everything about the parent space (creation, format, indexes) doubles the snippet size, making the mechanism look heavy and complex.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, I agree. As an idea for the future, it would be convenient to have smth like the
Open full sample
button in the right corner to have the capability to open the example right on the GithHub and understand the full context.