Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dest/escalation-policies: use destinations for EP step form #3717

Merged
merged 29 commits into from
Mar 12, 2024

Conversation

tony-tvu
Copy link
Collaborator

@tony-tvu tony-tvu commented Feb 27, 2024

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR adds an escalation policy step form component that utilizes generic destinations. This component will have no effect on the current state of the UI, even with experimental flag set to dest-types.

Which issue(s) this PR fixes:
Part of #2639

Out of Scope:
N/A

Screenshots:
Screenshot 2024-02-27 at 10 21 37 AM

Describe any introduced user-facing changes:
N/A

Describe any introduced API changes:
N/A

Additional Info:
N/A

@tony-tvu tony-tvu changed the title dest/escalation-policies: use destinations for EP form dest/escalation-policies: use destinations for EP step form Feb 27, 2024
@github-actions github-actions bot added size/xl and removed size/l labels Feb 27, 2024
@github-actions github-actions bot added size/l and removed size/xl labels Feb 27, 2024
@github-actions github-actions bot added size/xl and removed size/l labels Feb 29, 2024
@github-actions github-actions bot added size/l and removed size/xl labels Feb 29, 2024
@github-actions github-actions bot removed the size/l label Feb 29, 2024
@github-actions github-actions bot added size/l and removed size/xl labels Feb 29, 2024
@github-actions github-actions bot added size/xl and removed size/l labels Mar 11, 2024
@github-actions github-actions bot added size/l and removed size/xl labels Mar 11, 2024
@ethan-haynes ethan-haynes merged commit 2ff4427 into master Mar 12, 2024
7 checks passed
@ethan-haynes ethan-haynes deleted the ep-step-form-dest branch March 12, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants