-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dest/escalation-policies: use destinations for EP step create dialog #3718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
web/src/app/escalation-policies/PolicyStepCreateDialogDest.stories.tsx
Outdated
Show resolved
Hide resolved
mastercactapus
previously approved these changes
Mar 13, 2024
mastercactapus
approved these changes
Mar 13, 2024
allending313
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make check
to catch common errors. Fixed any that came up.Description:
This PR adds an escalation policy step create dialog component which utilizes generic destinations when experimenta flag is set to
dest-types
. This PR cannot be merged until #3717 has been approved and merged first. After #3717 has been merged, the amount of code line changes for this PR should fall below 500. Along with component tests, a playwright integration test has been added to verify we can create an EP step with multiple actions.Which issue(s) this PR fixes:
Part of #2639
Out of Scope:
N/A
Screenshots:
Describe any introduced user-facing changes:
The UI will no longer use Material-UI's accordion component when creating a new escalation policy step. Instead, it will utilize a simplified menu selector where users will view and add a single action at a time.
Describe any introduced API changes:
N/A
Additional Info:
N/A