Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dest/escalation-policies: use destinations for EP step create dialog #3718

Merged
merged 30 commits into from
Mar 18, 2024

Conversation

tony-tvu
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR adds an escalation policy step create dialog component which utilizes generic destinations when experimenta flag is set to dest-types. This PR cannot be merged until #3717 has been approved and merged first. After #3717 has been merged, the amount of code line changes for this PR should fall below 500. Along with component tests, a playwright integration test has been added to verify we can create an EP step with multiple actions.

Which issue(s) this PR fixes:
Part of #2639

Out of Scope:
N/A

Screenshots:
create ep

Screenshot 2024-02-27 at 10 36 34 AM create

Describe any introduced user-facing changes:
The UI will no longer use Material-UI's accordion component when creating a new escalation policy step. Instead, it will utilize a simplified menu selector where users will view and add a single action at a time.

Describe any introduced API changes:
N/A

Additional Info:
N/A

@mastercactapus mastercactapus marked this pull request as draft March 12, 2024 15:43
@mastercactapus mastercactapus marked this pull request as ready for review March 12, 2024 20:38
@github-actions github-actions bot added size/l and removed size/xl labels Mar 12, 2024
@mastercactapus mastercactapus marked this pull request as draft March 12, 2024 21:49
@mastercactapus mastercactapus marked this pull request as ready for review March 13, 2024 18:43
mastercactapus
mastercactapus previously approved these changes Mar 13, 2024
@mastercactapus mastercactapus merged commit 688542c into master Mar 18, 2024
7 checks passed
@mastercactapus mastercactapus deleted the ep-step-create-dialog-dest-ui branch March 18, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants