Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minimal changes to get vn reg working with rfc-0313 #209

Merged
merged 6 commits into from
Nov 21, 2022

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Nov 17, 2022

Description

  • get_consensus_constants grpc updates
  • update vn reg signature
  • update cargo.lock
  • move OnEpochChange handler code into function
  • fix bug where if the validator node is not registered it would return an error
  • fix epoch not found bug
  • fix genesis newview QC is always rejected

Motivation and Context

RFC-0313

Ref tari-project/tari#4928

How Has This Been Tested?

Manually - registering 3 validators from clean igor chain

@sdbondi sdbondi marked this pull request as ready for review November 17, 2022 14:34
@sdbondi sdbondi force-pushed the base-node-vn-reg-changes branch from f7cde63 to 76ffb77 Compare November 18, 2022 09:28
@sdbondi sdbondi force-pushed the base-node-vn-reg-changes branch from 0f46b8e to ecae877 Compare November 18, 2022 09:50
Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@sdbondi sdbondi merged commit 3c99e78 into tari-project:development Nov 21, 2022
@sdbondi sdbondi deleted the base-node-vn-reg-changes branch November 21, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants