feat!: implement validator node registration as per RFC-0313 #4928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description --- Minor updates for a corresponding [change](tari-project/tari_utilities#52) to the `SafePassword` API. Motivation and Context --- A pending change in `tari_utilities` to the handling of sensitive data includes a new implementation of `SafePassword`. One change removes derived traits for equality testing in favor of equality testing on references to the underlying passphrase data. This work makes the minor but necessary changes to address this API change. How Has This Been Tested? --- Tests pass after applying the linked `tari_utilities` PR. Note that tests will pass using the current `SafePassword` API as well, as the dependency change PR restricts the API.
Delete some unused methods
…ri-project#4807) (tari-project#4911) Description --- When wallet starts new UTXO scanning service it should start at the birthday. Currently, it starts at height 0. This PR addresses this issue Motivation and Context --- Addresses tari-project#4807. How Has This Been Tested? ---
sdbondi
force-pushed
the
core-vn-reg-impl-from-rfc
branch
3 times, most recently
from
9454226 to
14d8010
Compare
sdbondi
changed the title
Description --- Fixing the comments of one function in the wallet FFI. Fixes the names of 4 functions in the wallet FFI.
Description --- Fixes depreciated timestamp warnings
sdbondi
force-pushed
the
core-vn-reg-impl-from-rfc
branch
from
14d8010 to
f21a76b
Compare
sdbondi
changed the title
This is to allow the validator node to use the same signature
stringhandler
approved these changes
Nov 17, 2022
sdbondi
added a commit
to tari-project/tari-dan
that referenced
this pull request
Nov 21, 2022
Description --- - `get_consensus_constants` grpc updates - update vn reg signature - update cargo.lock - move OnEpochChange handler code into function - fix bug where if the validator node is not registered it would return an error - fix epoch not found bug - fix genesis newview QC is always rejected Motivation and Context --- [RFC-0313](https://rfc.tari.com/RFC-0313_VNRegistration.html) Ref tari-project/tari#4928 How Has This Been Tested? --- Manually - registering 3 validators from clean igor chain
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Nov 28, 2022
* feature-dan: fix(core)!: sort validate set by shard key (tari-project#4952) update validator signature feat!: implement validator node registration as per RFC-0313 (tari-project#4928)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
insert,delete,get_vn_set,get_shard_keymethodsIncludes changes from development
Motivation and Context
RFC-0313
How Has This Been Tested?
Additional unit tests