Update tari-common crate feature flags to exclude git2 from lib_wallet build
#3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…let build This PR adds a feature flag to the Tari-common crate so that the git2 dependency can be excluded from he building of Core. This dependency contains a C dependency (libgit2) that breaks the LibWallet build.
StriderDM
approved these changes
Jul 8, 2021
There was a problem hiding this comment.
Nice @philipr-za.
Approving so long, will start checking the docker builds for github actions with this and the updated nightly version.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a feature flag to the Tari-common crate so that the git2 dependency can be excluded from he building of Core. This dependency contains a C dependency (libgit2) that breaks the LibWallet build.
How Has This Been Tested?
Manually tested
Checklist:
developmentbranch.