Github action fixes and mobile_build script cleanup #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StriderDM
force-pushed
the
mobile_build_script_fixes
branch
from
51e8970 to
e677203
Compare
Restored ${PKG_PATH} variable
Restored universal directory for iOS
Resolved warnings in mobile_build.sh
Make libsqlite3-sys an optional dependency
StriderDM
force-pushed
the
mobile_build_script_fixes
branch
from
e677203 to
17a60e4
Compare
aviator-app bot
pushed a commit
that referenced
this pull request
Sep 22, 2021
Description --- Include vendored openssl library when not building ffi wallet library. Exclude vendored openssl library when building ffi wallet library as it needs to be cross compiled for mobile which is done in mobile_build.sh. Merge #3285 first. We had to do the same for sqlite here: #3073 Motivation and Context --- Current:  This PR:  [mobile_build_logs.zip](https://github.com/tari-project/tari/files/7104686/mobile_build_logs.zip) How Has This Been Tested? --- cargo test --all --all-features nvm use v12.22.6 && ./node_modules/.bin/cucumber-js features/WalletFFI.feature sh mobile_build.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restored ${PKG_PATH} variable for iOS
Restored universal directory for iOS
Resolved warnings in mobile_build.sh
Made libsqlite3-sys an optional dependency and filtered it out in wallet_ffi for android
Merge #3072 first since this PR is built on top of it.
Motivation and Context
Necessary for the build script to work correctly as well as the github action
How Has This Been Tested?
Docker locally.
Checklist:
developmentbranch.