feat!: add deleted height to unique_id index #3506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds the spend/deleted height to the asset id index when a unique id UTXO is spent - head unique_id (ie. <asset_pk, unique_id> in current UTXO set) has "special" key in unique_id_index - handle reorg code to update unique_id_index - replace hex string keys with byte keys in kernel and input dbs - add test for fetch_utxo_by_unique_id with deleted height param
sdbondi
force-pushed
the
core-unique-id-index-incl-parent-pk
branch
from
d1ef6ee to
cfd451e
Compare
sdbondi
changed the title
|
Looks great, yes some tests were failing before this. Just a lil clippy |
|
👌 I'll give some 📎 ❤️ |
* validator-node: tests!: add unique_id block validator tests (tari-project#3510)
* validator-node: feat: add file uploading to ipfs for asset create (tari-project#3524) test!: add additional tests for unique asset id validation (tari-project#3517)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UTXO is spent
"special" key in unique_id_index
Motivation and Context
Allow fetch_utxo_by_unique_id to query the "head" UTXO that existed at any height
How Has This Been Tested?
Unit tests
Some tests are failing but I suspect this was already the case before this PR