Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed code duplication in TariUtxo conversion #4283

Merged

Conversation

agubarev
Copy link
Contributor

@agubarev agubarev commented Jul 7, 2022

Description

Removed redundant code.

Motivation and Context

Unnecessary code duplication.

How Has This Been Tested?

unit tests

Signed-off-by: Andrei Gubarev <agubarev@users.noreply.github.com>
@agubarev agubarev changed the title wallet_ffi: removed code duplication in TariUtxo conversion fix: removed code duplication in TariUtxo conversion Jul 7, 2022
@aviator-app aviator-app bot merged commit 455d161 into tari-project:testnet-dibbler Jul 7, 2022
sdbondi added a commit to sdbondi/tari that referenced this pull request Jul 22, 2022
* testnet-dibbler: (29 commits)
  refactor(launchpad): move launchpad to its own repo (tari-project#4323)
  feat: tari launchpad downstream merge (tari-project#4322)
  feat: bump toolchain for GHA from nightly-2021-11-20 to nightly-2022-05-01 (tari-project#4308)
  fix: fix OSX GHA build fix by bumping OSX release (tari-project#4300)
  v0.32.12
  fix: cbindgen fix (tari-project#4298)
  v0.32.11
  chore: wallet ffi refactor (tari-project#4295)
  fix: fixed bug in wallet_coin_join (tari-project#4290)
  v0.32.10
  feat(wallet_ffi): added mined_timestamp to TariUtxo (tari-project#4284)
  fix: removed code duplication in TariUtxo conversion (tari-project#4283)
  fix: improve GHA docker image builds (tari-project#4257)
  feat: add mined_timestamp to wallet.db (tari-project#4267)
  chore(deps): docker gha builds (tari-project#4274)
  chore(deps): improve xmrig docker builds (tari-project#4273)
  v0.32.9
  feat(ffi): added 3 functions (tari-project#4266)
  ffi: added 2 functions, wallet_preview_coin_split and wallet_preview_coin_join (tari-project#4264)
  v0.32.8
  ...
@agubarev agubarev deleted the wallet_ffi_code_dedup branch July 28, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants