chore: wallet ffi refactor #4295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed TariOutputs refactored TariVector helper methods Signed-off-by: Andrei Gubarev <agubarev@users.noreply.github.com>
stringhandler
approved these changes
Jul 11, 2022
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jul 22, 2022
* testnet-dibbler: (29 commits) refactor(launchpad): move launchpad to its own repo (tari-project#4323) feat: tari launchpad downstream merge (tari-project#4322) feat: bump toolchain for GHA from nightly-2021-11-20 to nightly-2022-05-01 (tari-project#4308) fix: fix OSX GHA build fix by bumping OSX release (tari-project#4300) v0.32.12 fix: cbindgen fix (tari-project#4298) v0.32.11 chore: wallet ffi refactor (tari-project#4295) fix: fixed bug in wallet_coin_join (tari-project#4290) v0.32.10 feat(wallet_ffi): added mined_timestamp to TariUtxo (tari-project#4284) fix: removed code duplication in TariUtxo conversion (tari-project#4283) fix: improve GHA docker image builds (tari-project#4257) feat: add mined_timestamp to wallet.db (tari-project#4267) chore(deps): docker gha builds (tari-project#4274) chore(deps): improve xmrig docker builds (tari-project#4273) v0.32.9 feat(ffi): added 3 functions (tari-project#4266) ffi: added 2 functions, wallet_preview_coin_split and wallet_preview_coin_join (tari-project#4264) v0.32.8 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced and removed TariOuputs, now using TariVector to return UTXOS. Refactored TariVector helper methods.
Added new parameter
statestowallet_get_utxos()to filter result by OutputStatus.Motivation and Context
Code deduplication and overall quality of life improvements.
How Has This Been Tested?
unit tests