fix: computation of vn mmr #4772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
approved these changes
Oct 4, 2022
stringhandler
approved these changes
Oct 11, 2022
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Nov 14, 2022
* feature-dan: (21 commits) fix(core)!: remove unused get_committees call from base node (tari-project#4880) fix: correct value for validator_node_timeout consensus constant in localnet (tari-project#4879) feat: add block height to input request to get network consensus constants (tari-project#4856) fix: remove unused config for validator node (tari-project#4849) feat: add missing fields to grpc consensus constants interface (tari-project#4845) chore: merge development into feature-dan (tari-project#4815) refactor: split tari_base_node and tari_console_wallet into a lib component (tari-project#4818) fix(core)!: adds utxo and block info to get_template_registrations request (tari-project#4789) fix: computation of vn mmr (tari-project#4772) fix(wallet/grpc): add transaction id and template_address to template_reg response (tari-project#4788) fix: fix get shard key (tari-project#4744) feat(core): store and fetch templates from lmdb (tari-project#4726) fix: fix validator node registration logic (tari-project#4718) feat(base_node_grpc_client): add getActiveValidatorNodes method (tari-project#4719) fix after merge fix(core): bring validator node MR inline with other merkle root code (tari-project#4692) feat(core): add validator registration sidechain feature (tari-project#4690) fix merge issues feat: add grpc to get shard key for public key (tari-project#4654) feat: add validator node registration (tari-project#4507) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the VNs mmr. The output vector was in random order that resulted in the mmr being kind of random as well.
So the miner and base node had different order of VNs and the blocks were invalidated. More VNs = less probability of passing.
How Has This Been Tested?
I manually registered 27 VNs and mined 100 blocks.